-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hung add test ProcessBandOraclePrices #24
Merged
ThanhNhann
merged 8 commits into
onomyprotocol:nhan/oracle_module
from
hungdinh82:hung_oracle_module_test_ProcessBandOraclePrices
Oct 4, 2024
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
04c4490
add test ProcessBandOraclePrices
hungdinh82 bfe2c30
add testProcessBandOraclePrices
hungdinh82 b939f07
Merge remote-tracking branch 'upstream/nhan/oracle_module' into hung_…
hungdinh82 df18d72
Merge branch 'nhan/oracle_module' into hung_oracle_module_test_Proces…
hungdinh82 0605596
merge
hungdinh82 af1cbda
fix test update
hungdinh82 b525b15
fix test update
hungdinh82 4844705
fix test update 3
hungdinh82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get the
PriceState.Price
and compare instead of rate hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to check whether
BandCallDataRecord
was deleted after this linek.DeleteBandCallDataRecord(ctx, uint64(clientID))