Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: support zone association #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

enhancement: support zone association #3

wants to merge 6 commits into from

Conversation

xshot9011
Copy link
Contributor

@xshot9011 xshot9011 commented Jul 28, 2022 •
edited
Loading

Submit a pull request 🚀

Thank you for help us contribute! Please give us more information about this PR.

What 😗

Added

  • Add variable var.is_ignore_vpc_changes to decide which host zone to use
    • Add resource aws_route53_zone.this_ignore_vpc for integration with private zone route association
  • Add local variables local.zone_name using at outputs.tf

Changed

  • Move all locals into main.tf
  • Move usage in README to examples/simple folder
  • Update local.zone_id condition when use with variables var.is_ignore_vpc_changes
  • Output result support multiple resource creation

Why 🥺

  • To prevent the deletion of associated VPCs after the initial creation

Other Info-

@xshot9011 xshot9011 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 28, 2022
@xshot9011 xshot9011 requested a review from a team July 28, 2022 13:29
@xshot9011 xshot9011 self-assigned this Jul 28, 2022
@xshot9011 xshot9011 marked this pull request as ready for review July 28, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xshot9011 xshot9011

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xshot9011