Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

feat: enable mpas for replication controller #151

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 30, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added e2e-tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for e2e-tests

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso requested review from phoban01 and souleb November 30, 2023 18:14
Copy link

github-actions bot commented Nov 30, 2023

Mend Scan Summary: ❌

Repository: open-component-model/MPAS

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 3
LICENSE RISK HIGH 7
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 1

Detailed Logs: mend-scan-> Generate Report
Mend UI

@Skarlso Skarlso force-pushed the enable-replication-controller-mpas branch 2 times, most recently from 19c3e83 to 6556518 Compare November 30, 2023 18:29
@Skarlso Skarlso force-pushed the enable-replication-controller-mpas branch from 6556518 to 987c015 Compare November 30, 2023 18:35
@Skarlso Skarlso force-pushed the enable-replication-controller-mpas branch from ca00295 to f7818be Compare December 4, 2023 07:40
@Skarlso
Copy link
Contributor Author

Skarlso commented Dec 4, 2023

The reason I haven't merged this yet is for whatever reason, the bootstrap doesn't bootstrap it right. I don't know.

The deployed end result doesn't have the arguments even though the content during bootstrapping has it.

Command:                                                                                                                    │
│       /manager                                                                                                                  │
│     Args:                                                                                                                       │
│       --leader-elect                                                                                                            │
│       --zap-log-level=4       

Meanwhile during bootstrapping:

---
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    control-plane: replication-controller
  name: replication-controller
  namespace: ocm-system
spec:
  replicas: 1
  selector:
    matchLabels:
      control-plane: replication-controller
  template:
    metadata:
      annotations:
        kubectl.kubernetes.io/default-container: manager
      labels:
        control-plane: replication-controller
    spec:
      containers:
      - args:
        - --mpas-enabled
        - --leader-elect
        - --zap-log-level=4

I'm not sure what's going on here.

@Skarlso Skarlso merged commit 5b6d976 into main Dec 4, 2023
6 of 7 checks passed
@Skarlso Skarlso deleted the enable-replication-controller-mpas branch March 25, 2024 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants