Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

updating e2e to adapt to mpas-product-controller with cuelang #156

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

souleb
Copy link
Contributor

@souleb souleb commented Dec 4, 2023

Description

updating e2e to adapt to the change made in mpas-product-controller, i.e. using cuelang for configuration and validation.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added e2e-tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for e2e-tests

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…dation

Signed-off-by: Soule BA <bah.soule@gmail.com>
Copy link

github-actions bot commented Dec 4, 2023

Mend Scan Summary: ❌

Repository: open-component-model/MPAS

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 3
LICENSE RISK HIGH 7
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 1

Detailed Logs: mend-scan-> Generate Report
Mend UI

…dation

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the adapt-e2e-to-cuelang branch from 37770f1 to ce3c401 Compare December 4, 2023 09:44
@Skarlso
Copy link
Contributor

Skarlso commented Dec 4, 2023

-- PASS: TestMpasE2e (236.15s)
PASS
ok      github.com/open-component-model/mpas/e2e        310.815s

DONE 40 tests in 330.580s

Passes locally. Let's see what the runner has to say.

@souleb souleb requested a review from phoban01 December 4, 2023 13:54
@souleb souleb merged commit 3b7a50f into main Dec 4, 2023
7 checks passed
@Skarlso Skarlso deleted the adapt-e2e-to-cuelang branch March 25, 2024 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants