This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piaras Hoban <phoban01@gmail.com>
Mend Scan Summary: ❌Repository: open-component-model/MPAS
|
morri-son
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just added a link to the ocm.software page in the bootstrap.md
souleb
reviewed
Dec 7, 2023
kubectl describe productdeployment -n mpas-podinfo-application | ||
``` | ||
|
||
The result should look something like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truth is at this point it won't work. Two reasons
- The deployed helmRepository has not secret set that would permit pulling the helmcharts. So we need to add a step for the user to make the chart public until we address this shortcoming.
- The deployed podinfo
deployment
doesn't have thepullImageSecret
. In order to solve this, the user should update theconfig.cue
to add aserviceAccountName
. The name should be the one generated bytarget
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a note
Skarlso
reviewed
Dec 8, 2023
Skarlso
reviewed
Dec 8, 2023
phoban01
force-pushed
the
phoban01/docs-update
branch
from
December 19, 2023 18:01
53c85ff
to
19d8cf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the MPAS documentation site.
Signed-off-by: Piaras Hoban phoban01@gmail.com