Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Gosec - enable security linting #1266

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Jan 23, 2025

What this PR does / why we need it

SAST scans with appropriate linters is a requirement in the context of the OpenSSF/CII badge.

sample status / sample results

In case of: Error: Resource not accessible by integration, double check the OCM-bot permissions (or the used token) and ensure that GHAS is enabled.

Which issue(s) this PR fixes

open-component-model/ocm-project#270

@github-actions github-actions bot added kind/chore chore, maintenance, etc. component/github-actions Changes on GitHub Actions or within `.github/` directory size/s Small labels Jan 23, 2025
@hilmarf hilmarf linked an issue Jan 23, 2025 that may be closed by this pull request
8 tasks
@hilmarf hilmarf marked this pull request as ready for review January 24, 2025 13:37
@hilmarf hilmarf requested a review from a team as a code owner January 24, 2025 13:37
without any TOKEN declaration it's working

Signed-off-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@hilmarf hilmarf added area/security Security relevant area/cicd Continuous Integration and Continuous Deployment related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related labels Jan 29, 2025
Co-authored-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>
@github-actions github-actions bot added size/xs Extra small and removed size/s Small labels Jan 29, 2025
Signed-off-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>
@github-actions github-actions bot added size/s Small and removed size/xs Extra small labels Jan 30, 2025
Copy link
Contributor

@morri-son morri-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hilmarf hilmarf merged commit d1c40af into open-component-model:main Feb 4, 2025
25 checks passed
@hilmarf hilmarf deleted the gosec branch February 4, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd Continuous Integration and Continuous Deployment related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/security Security relevant component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc. size/s Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable security linting - ocm
3 participants