Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add hub/device tabs when selected in the editor #24

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Automatically add hub/device tabs when selected in the editor #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b66ac2
Update tabs when dropdown changes
bparks13 Feb 7, 2025
dd6b2d3
Refresh tabs, ensuring settings match connected hardware
bparks13 Feb 21, 2025
8990760
Check existing channel presets
bparks13 Mar 3, 2025
b8e1d27
Block changing settings tabs when hardware is connected
bparks13 Mar 4, 2025
b1b568e
Add leak detectors to all classes
bparks13 Mar 4, 2025
ea2bb00
Merge branch 'main' into issue-5
bparks13 Mar 4, 2025
cb88147
Fix merge conflicts
bparks13 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Devices/Bno055.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ int Bno055::enableDevice()
return 0;
}

int Bno055::updateSettings()
bool Bno055::updateSettings()
{
return 0;
return true;
}

void Bno055::startAcquisition()
Expand Down
6 changes: 4 additions & 2 deletions Source/Devices/Bno055.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class Bno055 : public OnixDevice
int enableDevice() override;

/** Update the settings of the device */
int updateSettings() override;
bool updateSettings() override;

/** Starts probe data streaming */
void startAcquisition() override;
Expand Down Expand Up @@ -84,6 +84,8 @@ class Bno055 : public OnixDevice

unsigned short currentFrame = 0;
int sampleNumber = 0;

JUCE_LEAK_DETECTOR(Bno055);
};

#endif
#endif
1 change: 1 addition & 0 deletions Source/Devices/HeadStageEEPROM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ class HeadStageEEPROM :
static const uint32_t EEPROM_ADDRESS = 0x51;
static const uint32_t DEVID_START_ADDR = 18;

JUCE_LEAK_DETECTOR(HeadStageEEPROM);
};

4 changes: 2 additions & 2 deletions Source/Devices/Neuropixels2e.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ int Neuropixels2e::enableDevice()

}

int Neuropixels2e::updateSettings()
bool Neuropixels2e::updateSettings()
{
return 0;
return true;
}

void Neuropixels2e::configureProbeStreaming()
Expand Down
5 changes: 3 additions & 2 deletions Source/Devices/Neuropixels2e.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class Neuropixels2e :
int enableDevice() override;

/** Update the settings of the device */
int updateSettings() override;
bool updateSettings() override;

/** Starts probe data streaming */
void startAcquisition() override;
Expand Down Expand Up @@ -115,4 +115,5 @@ class Neuropixels2e :

Array<oni_frame_t*, CriticalSection, 2 * FramesPerSuperFrame> frameArray;

};
JUCE_LEAK_DETECTOR(Neuropixels2e);
};
Loading