Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geneva, User Events] Update CMakeLists.txt #408

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[Geneva, User Events] Update CMakeLists.txt #408

merged 2 commits into from
Apr 3, 2024

Conversation

Pravila00
Copy link
Contributor

@Pravila00 Pravila00 commented Mar 28, 2024 •
edited
Loading

Changes

  • Rename BUILD_EXAMPLE to WITH_EXAMPLES to be consistent with opentelemetry-cpp repository.
  • Add option to skip the build of Tracepoints library. This will be used for Vcpkg build, as we will set Tracepoint library as a dependency of the feature.
  • Replace usage of CMAKE_CXX_STANDARD by target_compile_features.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Pravila00 Pravila00 marked this pull request as ready for review March 28, 2024 14:53
@Pravila00 Pravila00 requested a review from a team March 28, 2024 14:53
@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Mar 28, 2024
@ThomsonTan ThomsonTan added the exporter:geneva Geneva Exporter label Mar 28, 2024
@Pravila00 Pravila00 changed the title Update CMakeLists.txt arguments of Geneva and User Events exporters for Vcpkg build [Geneva, User Events] Update CMakeLists.txt Apr 2, 2024
@Pravila00 Pravila00 force-pushed the pabloro/update-cmake-file branch from b25d933 to 9dc0acb Compare April 3, 2024 10:32
@Pravila00
Copy link
Contributor Author

Pravila00 commented Apr 3, 2024 •
edited
Loading

I've just modified my commit history for using only this GitHub account where I have CLA access, we should be good now :)
Would you mind checking if everything is still okay @lalitb? Thanks for the review!

@ThomsonTan ThomsonTan removed the pr:waiting-on-cla Waiting on CLA label Apr 3, 2024
@ThomsonTan ThomsonTan merged commit 4f30593 into open-telemetry:main Apr 3, 2024
3 checks passed
@marcalff marcalff added the exporter:user_events User_Events Exporter label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
exporter:geneva Geneva Exporter exporter:user_events User_Events Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pravila00 @ThomsonTan @lalitb @marcalff