-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVCONTAINER] support customization and run as non-root user #3270
Merged
marcalff
merged 12 commits into
open-telemetry:main
from
dbarker:fix_devcontainer_permissions
Feb 21, 2025
Merged
[DEVCONTAINER] support customization and run as non-root user #3270
marcalff
merged 12 commits into
open-telemetry:main
from
dbarker:fix_devcontainer_permissions
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
dbarker
commented
Feb 12, 2025
…buf version and compatible abseil version from ci. Override the base image's entrypoint to support running just an interactive bash session in docker. Add a readme with config details.
Thanks for the PR. @esigo Could you take a look ? Thanks. |
esigo
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks perfect
thanks for the pr :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3265
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes