Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fixes compatibility of type_traits #3274

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

owent
Copy link
Member

@owent owent commented Feb 13, 2025

Fixes #3273

Changes

  • Make type traits the same when OPENTELEMETRY_STL_VERSION>=2011 or not
  • Do not use auto as parameter of lambda to support legacy toolchain.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner February 13, 2025 11:25
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit fa49657
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67aeae7c297af40008f57258

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (3ca3c76) to head (fa49657).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772           

@owent owent requested a review from chusitoo February 14, 2025 02:46
@owent owent changed the title Fixes 3273 Fixes type_traits when OPENTELEMETRY_STL_VERSION>=2011 Feb 14, 2025
@owent owent changed the title Fixes type_traits when OPENTELEMETRY_STL_VERSION>=2011 Fixes compatibility of type_traits Feb 14, 2025
Copy link
Contributor

@chusitoo chusitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Fixes compatibility of type_traits [BUILD] Fixes compatibility of type_traits Feb 14, 2025
@marcalff marcalff merged commit 2f58e95 into open-telemetry:main Feb 14, 2025
57 checks passed
@owent owent deleted the fix_type_traits branch February 21, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build with legacy toolchain and type traits are not the same when enable/disable C++11's STL.
3 participants