-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introducing uv in core #4451
base: main
Are you sure you want to change the base?
introducing uv in core #4451
Conversation
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@@ -95,7 +95,7 @@ envlist = | |||
public-symbols-check | |||
shellcheck | |||
generate-workflows | |||
ruff | |||
precommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tox -e ruff
still runs even if ruff isn't in envlist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tox list | grep ruff
ruff -> [no description]
Description
Same as open-telemetry/opentelemetry-python-contrib#3124
Also, I'm adding a new workflow called
precommit
which now makes more sense. I'm keepingruff
in tox just for convenience for contributors as requested here