Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing uv in core #4451

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

introducing uv in core #4451

wants to merge 6 commits into from

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Feb 27, 2025

Description

Same as open-telemetry/opentelemetry-python-contrib#3124

Also, I'm adding a new workflow called precommit which now makes more sense. I'm keeping ruff in tox just for convenience for contributors as requested here

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner February 27, 2025 14:48
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 27, 2025
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@@ -95,7 +95,7 @@ envlist =
public-symbols-check
shellcheck
generate-workflows
ruff
precommit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox -e ruff still runs even if ruff isn't in envlist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox list | grep ruff
ruff                                                -> [no description]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants