Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve email value when switching login type #108

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

codersjj
Copy link
Contributor

Resolves: #106

Copy link

vercel bot commented Jan 25, 2025

@codersjj is attempting to deploy a commit to the OpenBuild Team on Vercel.

A member of the Team first needs to authorize it.

@ourai ourai self-requested a review January 25, 2025 03:26
@ourai ourai self-assigned this Jan 25, 2025
@ourai ourai added the bug Something isn't working label Jan 25, 2025
@ourai ourai added this to the 2025W04 milestone Jan 25, 2025
Copy link
Member

@ourai ourai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run pnpm run lint --fix before commit this time please

@codersjj
Copy link
Contributor Author

run pnpm run lint --fix before commit this time please

I noticed that the project already uses lint-staged to run lint during the pre-commit hook. So, why is it necessary to manually run pnpm run lint --fix before committing? 😕

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
openbuild-frontend ✅ Ready (Inspect) Visit Preview Jan 25, 2025 9:30am

@ourai
Copy link
Member

ourai commented Jan 25, 2025

run pnpm run lint --fix before commit this time please

I noticed that the project already uses lint-staged to run lint during the pre-commit hook. So, why is it necessary to manually run pnpm run lint --fix before committing? 😕

I want to let developers know what happened on their codes, so I prefer to:

  • Linter tells them that something is wrong, then they go to fix it.
  • They auto fix locally via IDE plugins.

What I (or somebody else) need to do is that to make semicolon detection strict.

@ourai ourai mentioned this pull request Jan 25, 2025
2 tasks
@ourai ourai merged commit 2c5d175 into openbuildxyz:test Jan 25, 2025
2 checks passed
@codersjj
Copy link
Contributor Author

run pnpm run lint --fix before commit this time please

I noticed that the project already uses lint-staged to run lint during the pre-commit hook. So, why is it necessary to manually run pnpm run lint --fix before committing? 😕

I want to let developers know what happened on their codes, so I prefer to:

  • Linter tells them that something is wrong, then they go to fix it.
  • They auto fix locally via IDE plugins.

What I (or somebody else) need to do is that to make semicolon detection strict.

Got it, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

切换登录方式时应保留已填邮箱
2 participants