Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Quiz Rankings and UI Optimization & Fix Challenge Dialog Flickering Issue #87

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

Coooder-Crypto
Copy link
Contributor

PR Description

This PR includes the following changes:

  1. Enhancements for Quiz: Add Entry for Viewing All Rankings and UI Optimization

    • Support Markdown formatting for the Quiz description:
    • Added an entry to view all rankings:
      • Clicking the total number of participants below the leaderboard will open a dialog displaying a list in the same style as the leaderboard.
      • Encapsulated the leaderboard list into a reusable component.
      • The dialog is implemented as a standalone component and stored in the same-level folder as the page.
  2. Bug Fix: Resolved Flickering Issue When Closing the Challenge Dialog

    • Fixed the flickering issue that occurred when closing the Challenge dialog, improving the user experience.

Notes

  • Markdown support for the Quiz description has been tested to ensure proper display on both the details and list pages.
  • The leaderboard-related components have been encapsulated and reused, resulting in a cleaner code structure.
  • The flickering issue with the Challenge dialog has been resolved and verified.

Related Issue


Please review the code and provide feedback. Thank you! 😊


Copy link

vercel bot commented Jan 17, 2025

@Coooder-Crypto is attempting to deploy a commit to the OpenBuild Team on Vercel.

A member of the Team first needs to authorize it.

@ourai ourai self-assigned this Jan 18, 2025
@ourai ourai self-requested a review January 18, 2025 03:59
@ourai ourai linked an issue Jan 18, 2025 that may be closed by this pull request
3 tasks
const mediaUrl = useMediaUrl();

return (
<div className="flex flex-col h-full">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这层 div 多余的吧?

@ourai ourai added this to the 2025W03 milestone Jan 18, 2025
@Coooder-Crypto
Copy link
Contributor Author

哇,感谢雷叔的指导,今天一直在赶路,明天之前修复下这些问题~

@ourai ourai modified the milestones: 2025W03, 2025W04 Jan 19, 2025
<RankList my_rank={my_rank} list={data?.list} />
<Modal isOpen={shown} closeModal={onClose} container mode="640">
<ModalCloseIcon onClick={onClose} className="absolute top-[-48px] md:top-[-32px] right-0 md:right-[-32px] cursor-pointer" />
<div className="md:h-[600px] h-[400px] flex flex-col overflow-y-auto" style={{ borderRadius: 'inherit', overflow: 'hidden' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 Tailwind CSS 的 class 替代 style

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
openbuild-frontend ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:56am

@ourai ourai merged commit 3ec62ee into openbuildxyz:test Jan 24, 2025
2 checks passed
@ourai ourai added bug Something isn't working enhancement New feature or request labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Quiz 增加全部排名入口及界面优化
2 participants