Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat "Platform Variants", especially to add amd64, ppc64le, riscv64 #1172

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Reformat "Platform Variants", especially to add amd64, ppc64le, riscv64 #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions image-index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,15 @@ For the media type(s) that this document is compatible with, see the [matrix][ma
## Platform Variants

When the variant of the CPU is not listed in the table, values are implementation-defined and SHOULD be submitted to this specification for standardization.

| ISA/ABI | `architecture` | `variant` |
|-----------------|----------------|-------------|
| ARM 32-bit, v6 | `arm` | `v6` |
| ARM 32-bit, v7 | `arm` | `v7` |
| ARM 32-bit, v8 | `arm` | `v8` |
| ARM 64-bit, v8 | `arm64` | `v8` |
These values SHOULD match (or be similar to) their analog listed in [the Go Language document][go-environment2].
Copy link
Member Author

@tianon tianon Feb 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or be similar to)

This part makes me nuts, but I felt like I had to somehow address that GOARM does not use a v prefix, GOARM64 will not (at least initially) support v8 (without a minor, like v8.0), we don't do extra things like softfloat or sse2 in this field, etc SOMEHOW in this wording.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, i would be more explicit in tags that are supported. One can reference go constants as valid ones, but specify them explicitly.

There will always be variants that are not yet specified or relevant for go, but do make sense to be explicit for container images that contain code that was written in other languages. For example, whilst GOARM64 is already defined, it doesn't actually do anything different in go - but it does for gcc for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table below does include explicit examples, though 😅


| ISA/ABI | `architecture` | `variant` | Go analog |
|------------|----------------|-----------------------|-------------|
| ARM 32-bit | `arm` | `v6`, `v7`, `v8` | `GOARM` |
| ARM 64-bit | `arm64` | `v8`, `v8.1`, … | `GOARM64` |
| POWER8+ | `ppc64le` | `power8`, `power9`, … | `GOPPC64` |
| RISC-V | `riscv64` | `rva20u64`, … | `GORISCV64` |
| x86-64 | `amd64` | `v1`, `v2`, `v3`, … | `GOAMD64` |

## Example Image Index

Expand Down
Loading