This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
feat: introduce ansible-free docker image for edx-notes-api #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
changed the title
iamsobanjaved
commented
Apr 27, 2023
| @@ -33,7 +33,7 @@ services: | |||
| - ${DEVSTACK_WORKSPACE}/src:/edx/src | |||
| edx_notes_api: | |||
| volumes: | |||
| - ${DEVSTACK_WORKSPACE}/edx-notes-api:/edx/app/edx_notes_api/edx_notes_api | |||
| - ${DEVSTACK_WORKSPACE}/edx-notes-api:/edx/app/notes/ | |||
There was a problem hiding this comment.
[Note for reviewer] I have changed paths here because notes was already deployed on prod with the native Dockerfile, so instead of adjusting paths for prod as per devstack, I have adjusted paths for devstack as of production.
iamsobanjaved
commented
Apr 27, 2023
| @@ -5,9 +5,28 @@ set -eu -o pipefail | |||
| . scripts/colors.sh | |||
| set -x | |||
|
|
|||
| # Common provisioning tasks for IDAs, including requirements, migrations, oauth client creation, etc. | |||
| ./provision-ida.sh edx_notes_api edx-notes 18120 edx_notes_api | |||
There was a problem hiding this comment.
[Note for reviewer] Copied the content of the common provisioning script and adjusted paths.
iamsobanjaved
changed the title
leangseu-edx
approved these changes
Apr 28, 2023
iamsobanjaved
added a commit
that referenced
this pull request
May 10, 2023
* feat: introduce annsible-free docker image for edx-notes-apo * fix: update image name as per the pushing script * fix: remove extra commented lines * fix: remove env activation command
XLAR-8
pushed a commit
to XLAR-8/devstack
that referenced
this pull request
Jul 26, 2023
…unsupported#1053) * feat: introduce annsible-free docker image for edx-notes-apo * fix: update image name as per the pushing script * fix: remove extra commented lines * fix: remove env activation command
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
* feat: introduce annsible-free docker image for edx-notes-apo * fix: update image name as per the pushing script * fix: remove extra commented lines * fix: remove env activation command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in issue: openedx/edx-notes-api#303