refactor: code style refactoring

openedx · Mar 4, 2025 · 40e5cad · 40e5cad
1 parent 1ba3d95
commit 40e5cad
Showing 1 changed file with 43 additions and 45 deletions.
diff --git a/feedback/static/js/src/feedback.js b/feedback/static/js/src/feedback.js
@@ -1,27 +1,25 @@
 /* Javascript for FeedbackXBlock. */
 // Work-around so we can log in edx-platform, but not fail in Workbench
 if (typeof Logger === 'undefined') {
-    var Logger = {
-        log: function(a, b) {
-	    console.log(JSON.stringify(a)+"/"+JSON.stringify(a));
-	}
-    };
+	var Logger = {
+		log: function (a) {
+			console.log(JSON.stringify(a) + '/' + JSON.stringify(a));
+		}
+	};
 }
 
 function FeedbackXBlock(runtime, element) {
-    function likert_vote() {
-	var vote = 0;
-	if ($(".feedback_radio:checked", element).length === 0) {
-	    vote = -1;
-	} else {
-	    vote = parseInt($(".feedback_radio:checked", element).attr("data-id").split("_")[1]);
+	function getLikedVote() {
+		if ($('.feedback_radio:checked', element).length === 0) {
+			return -1;
+		}
+
+		return parseInt($('.feedback_radio:checked', element).attr('data-id').split('_')[1]);
 	}
-	return vote;
-    }
 
-    function feedback() {
-	return $(".feedback_freeform_area", element).val();
-    }
+	function getFeedbackMessage() {
+		return $('.feedback_freeform_area', element).val();
+	}
 
 	function updateVoteCount(data) {
 		if (data.success && data.aggregate && $('.feedback_vote_count', element).length) {
@@ -31,37 +29,37 @@ function FeedbackXBlock(runtime, element) {
 		}
 	}
 
-    function submit_feedback(freeform, vote) {
-	var feedback = {};
-	if(freeform) {
-	    feedback['freeform'] = freeform;
-	}
-	if(vote != -1) {
-	    feedback['vote'] = vote;
-	}
+	function submit_feedback(freeform, vote) {
+		var feedback = {};
+		if (freeform) {
+			feedback['freeform'] = freeform;
+		}
+		if (vote !== -1) {
+			feedback['vote'] = vote;
+		}
 
-	Logger.log("edx.feedbackxblock.submitted", feedback);
-	$.ajax({
-            type: "POST",
-            url: runtime.handlerUrl(element, 'feedback'),
-            data: JSON.stringify(feedback),
-	    success: function(data) {
-		$('.feedback_thank_you', element).text(data.response || '');
-		updateVoteCount(data);
-	    }
-        });
-    }
+		Logger.log('edx.feedbackxblock.submitted', feedback);
+		$.ajax({
+			type: 'POST',
+			url: runtime.handlerUrl(element, 'feedback'),
+			data: JSON.stringify(feedback),
+			success: function (data) {
+				$('.feedback_thank_you', element).text(data.response || '');
+				updateVoteCount(data);
+			}
+		});
+	}
 
-    $(".feedback_submit_feedback", element).click(function(eventObject) {
-	submit_feedback(feedback(), -1);
-    });
+	$('.feedback_submit_feedback', element).click(function () {
+		submit_feedback(getFeedbackMessage(), -1);
+	});
 
-    $('.feedback_radio', element).change(function(eventObject) {
-	Logger.log("edx.feedbackxblock.likert_changed", {"vote":likert_vote()});
-	submit_feedback(false, likert_vote());
-    });
+	$('.feedback_radio', element).change(function () {
+		Logger.log('edx.feedbackxblock.likert_changed', { vote: getLikedVote() });
+		submit_feedback(false, getLikedVote());
+	});
 
-    $('.feedback_freeform_area', element).change(function(eventObject) {
-	Logger.log("edx.feedbackxblock.freeform_changed", {"freeform":feedback()});
-    });
+	$('.feedback_freeform_area', element).change(function () {
+		Logger.log('edx.feedbackxblock.freeform_changed', { freeform: getFeedbackMessage() });
+	});
 }