Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get groups data from membership endpoint using enterprise client #565

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Feb 17, 2025

Description

JIRA -> ENT-10020

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-analytics-data-api doesn't install it
    • test-master.in if edx-analytics-data-api pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the edx-analytics-data-api requirements installed or if you checked out edx-enterprise-data into the src directory used by edx-analytics-data-api, you can run this command through an edx-analytics-data-api shell.
      • It would be ./manage.py makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in Travis, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-analytics-data-api to upgrade dependencies (including edx-enterprise-data)
    • This must be done after the version is visible in PyPi as make upgrade in edx-analytics-data-api will look for the latest version in PyPi.
    • Note: the edx-enterprise-data constraint in edx-analytics-data-api must also be bumped to the latest version in PyPi.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-10020 branch 5 times, most recently from 2c69e76 to 3d578da Compare February 19, 2025 12:56
@jajjibhai008 jajjibhai008 changed the title [WIP] feat: get groups data from membership endpoint using enterprise client feat: get groups data from membership endpoint using enterprise client Feb 24, 2025
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jajjibhai008 jajjibhai008 merged commit ee84fa9 into master Feb 25, 2025
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-10020 branch February 25, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants