Skip to content

Commit

Permalink
feat: update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
hamzawaleed01 committed Jan 24, 2024
1 parent 95071ab commit 0ef6ae6
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 46 deletions.
36 changes: 24 additions & 12 deletions integrated_channels/cornerstone/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def cornerstone_course_key_model():
return apps.get_model('cornerstone', 'CornerstoneCourseKey')


def cornerstone_request_log__model():
def cornerstone_request_log_model():
"""
Returns the ``CornerstoneAPIRequestLogs`` class.
"""
Expand Down Expand Up @@ -103,14 +103,26 @@ def store_cornerstone_api_calls(
"""
Creates new record in CornerstoneAPIRequestLogs table.
"""
cornerstone_request_log__model().objects.create(
user_agent=user_agent,
user_ip=user_ip,
enterprise_customer=enterprise_customer,
enterprise_customer_configuration_id=enterprise_customer_configuration_id,
endpoint=endpoint,
payload=payload,
time_taken=time_taken,
status_code=status_code,
response_body=response_body,
)
try:
cornerstone_request_log_model().objects.create(
user_agent=user_agent,
user_ip=user_ip,
enterprise_customer=enterprise_customer,
enterprise_customer_configuration_id=enterprise_customer_configuration_id,
endpoint=endpoint,
payload=payload,
time_taken=time_taken,
status_code=status_code,
response_body=response_body,
)
except Exception as e: # pylint: disable=broad-except
LOGGER.error(
f"[Cornerstone]: Error occurred while storing API call: {e}"
f"user_agent={user_agent}, user_ip={user_ip}, enterprise_customer={enterprise_customer}"
f"enterprise_customer_configuration_id={enterprise_customer_configuration_id},"
f"endpoint={endpoint}"
f"payload={payload}"
f"time_taken={time_taken}"
f"status_code={status_code}"
f"response_body={response_body}"
)
35 changes: 1 addition & 34 deletions tests/test_integrated_channels/test_cornerstone/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,51 +2,20 @@
Tests for Degreed2 client for integrated_channels.
"""

import datetime
import json
import unittest

import mock
import pytest
import requests
import responses
from freezegun import freeze_time
from six.moves.urllib.parse import urljoin

from django.apps.registry import apps

from enterprise.api_client.enterprise_catalog import EnterpriseCatalogApiClient
from enterprise.models import EnterpriseCustomerUser
from integrated_channels.cornerstone.client import CornerstoneAPIClient
from integrated_channels.exceptions import ClientError
from test_utils import factories

NOW = datetime.datetime(2017, 1, 2, 3, 4, 5, tzinfo=datetime.timezone.utc)
NOW_TIMESTAMP_FORMATTED = NOW.strftime("%F")


def create_course_payload():
return json.dumps(
{
"courses": [
{
"title": "title",
"summary": "description",
"image-url": "image",
"url": "enrollment_url",
"language": "content_language",
"external-id": "key",
"duration": "duration",
"duration-type": "Days",
}
],
},
sort_keys=True,
).encode("utf-8")


@pytest.mark.django_db
@freeze_time(NOW)
class TestCornerstoneApiClient(unittest.TestCase):
"""
Test Degreed2 API client methods.
Expand Down Expand Up @@ -85,7 +54,5 @@ def test_create_course_completion(self):
"test-learner@example.com", json.dumps(payload)
)

assert len(responses.calls) == 1
assert output == (200, '"{}"')
# assert len(responses.calls) == 2
# assert responses.calls[0].request.url == cornerstone_api_client.get_oauth_url()
# assert responses.calls[1].request.url == cornerstone_api_client.get_completions_url()

0 comments on commit 0ef6ae6

Please sign in to comment.