Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: selectable students waiting step #2025
feat: selectable students waiting step #2025
Changes from 3 commits
8d5ddb3
4e9ad72
63e6fee
cd9e786
f91c336
13440d2
0b72976
356f994
34f4fbc
021b3a0
2cc2a80
d46c1ae
d121722
d06e3fc
6199023
95892cb
8d8f657
4bdd07d
bcdb6a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about this feature flag definition living here? It makes sense from a code encapsulation perspective, but we also need to make sure that it makes it into the documented list, otherwise no one will know it exists.
@feanil do you know if the docs will pick this toggle up if it's defined here?
Either way, it should be documented, so @johnvente could you add a docstring for this flag like what's done in edx-platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree @pomegranited I will add the respective doc here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for documenting this flag @johnvente ! Just going to wait a bit to see what @feanil has to say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. haven't heard anything back, but I think the code tells us the answer.
@johnvente have you seen how the other feature flags are used by ORA2?
cf
edx-ora2/settings/base.py
Line 148 in 7c33111
edx-ora2/openassessment/xblock/config_mixin.py
Line 19 in 7c33111
I think we should follow that convention and move this flag + docs into an
ENABLE_ORA_SELECTABLE_LEARNER_WAITING_REVIEW
flag in lms/cms common ([e.g. like ENABLE_ORA_ALL_FILE_URLS in lms.common.env and cms.common.env), and use the ORA xblock.config_mixin to check the flag itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited I will go back here ASAP to review that meanwhile @feanil can take a look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johnvente , sorry for my delays here.
I've nudged Feanil on Slack, but if he doesn't get back to us, then I'll finish my review and merge this when I start my week on Tuesday.
CC @itsjeyd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @pomegranited! sorry for the delay, I've changed the feature flag as you mentioned now is called
ENABLE_ORA_SELECTABLE_LEARNER_WAITING_REVIEW
I updated the PR's description as wellThis file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.