Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Django to 4.2.10 for Quince - Security Patch #34195

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Feb 6, 2024

@openedx-webhooks
Copy link

Thanks for the pull request, @magajh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@mariajgrimaldi
Copy link
Member

Hi there! Is there a PR for master with this security patch?

@cmltaWt0 cmltaWt0 self-requested a review February 7, 2024 13:52
@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Feb 7, 2024

I've built the image with Tutor and run it.
This patch looks good to me. Just need to not forget to add it to master.

Separate note - current tutor master branch is unable to build the quince.master due to merged #34047 that breaks this patching https://github.com/overhangio/tutor/pull/986/files

Created a PR.

@cmltaWt0 cmltaWt0 merged commit c37d7ba into openedx:open-release/quince.master Feb 7, 2024
43 checks passed
@openedx-webhooks
Copy link

@magajh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@magajh magajh deleted the magajh/patch-django-quince-4.2.10 branch February 7, 2024 22:11
@magajh
Copy link
Contributor Author

magajh commented Feb 7, 2024

@mariajgrimaldi @cmltaWt0 There isn't an open PR for patching Django in the master branch yet. However, the master branch is configured with the edx-requirements-bot, which I believe should handle these updates and automatically open a PR for it. In any case, I'll keep an eye on this and the master branches of the other repositories to ensure the update is applied.

@magajh
Copy link
Contributor Author

magajh commented Feb 13, 2024

Here is the link to the PR where the Django security patch was applied to the master branch: #34225.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants