feat: improved handling of json errors (#759)

openedx · Feb 2, 2024 · 78fa8da · 78fa8da
1 parent 7fa647a
commit 78fa8da
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/enterprise_catalog/apps/api_client/discovery.py b/enterprise_catalog/apps/api_client/discovery.py
@@ -79,7 +79,15 @@ def _retrieve_metadata_for_content_filter(self, content_filter, page, request_pa
                 if exception:
                     raise exception
                 break
-        return response.json()
+        try:
+            return response.json()
+        except requests.exceptions.JSONDecodeError as err:
+            LOGGER.exception(
+                f'Invalid JSON while retrieving results from course-discovery for page {page}, '
+                f'resonse status code: {response.status_code}, '
+                f'response body: {response.text}'
+            )
+            raise err
 
     def _retrieve_course_reviews(self, request_params):
         """
@@ -120,7 +128,15 @@ def _retrieve_course_reviews(self, request_params):
                 if exception:
                     raise exception
                 break
-        return response.json()
+        try:
+            return response.json()
+        except requests.exceptions.JSONDecodeError as err:
+            LOGGER.exception(
+                f'Invalid JSON while retrieving course review results from course-discovery for page {page}, '
+                f'resonse status code: {response.status_code}, '
+                f'response body: {response.text}'
+            )
+            raise err
 
     def get_course_reviews(self, course_keys=None):
         """