feat: ability to include unlisted courses in catalogs #767
Conversation
johnnagro
force-pushed
the
johnnagro/ENT-8212/0
branch
3 times, most recently
from
e1e75c5 to
a025c53
Compare
johnnagro
force-pushed
the
johnnagro/ENT-8212/0
branch
from
a025c53 to
2f22378
Compare
| courses.extend(discovery_client.get_courses(query_params=query_params)) | ||
|
|
||
| return courses | ||
| return DiscoveryApiClient().fetch_courses_by_keys(course_keys) |
There was a problem hiding this comment.
moved this logic into the client, left the old signature to maintain tests
| programs.extend(discovery_client.get_programs(query_params=query_params)) | ||
|
|
||
| return programs | ||
| return DiscoveryApiClient().fetch_programs_by_keys(program_keys) |
There was a problem hiding this comment.
moved this logic into the client, left the old signature to maintain tests
| @@ -394,6 +376,10 @@ def _update_full_content_metadata_course(content_keys): | |||
| metadata_record.json_metadata['reviews_count'] = review.get('reviews_count') | |||
| metadata_record.json_metadata['avg_course_rating'] = review.get('avg_course_rating') | |||
|
|
|||
| # johnnagro ENT-8212 need to retransform after full pull | |||
There was a problem hiding this comment.
when we initially force-include the content, we need to mark it somehow so that the "full content metadata update job" knows to re-transform it on the full content metadata object it retrieves after the initial catalog crawl
| @@ -326,6 +346,48 @@ def get_programs(self, query_params=None): | |||
|
|
|||
| return programs | |||
|
|
|||
| def fetch_courses_by_keys(self, course_keys): | |||
There was a problem hiding this comment.
moved from tasks.py
|
|
||
| return courses | ||
|
|
||
| def fetch_programs_by_keys(self, program_keys): |
There was a problem hiding this comment.
moved from tasks.py
| @@ -102,6 +102,8 @@ | |||
| 'Certificación Profesional': 'Certificación Profesional', | |||
| } | |||
|
|
|||
| FORCE_INCLUSION_METADATA_TAG_KEY = 'enterprise_force_included' | |||
There was a problem hiding this comment.
magic field which marks content metadata as having been force-included
| @@ -394,6 +376,10 @@ def _update_full_content_metadata_course(content_keys): | |||
| metadata_record.json_metadata['reviews_count'] = review.get('reviews_count') | |||
| metadata_record.json_metadata['avg_course_rating'] = review.get('avg_course_rating') | |||
|
|
|||
| # johnnagro ENT-8212 need to retransform after full pull | |||
| if metadata_record.json_metadata.get(FORCE_INCLUSION_METADATA_TAG_KEY): | |||
| metadata_record.json_metadata = transform_course_metadata_to_visible(metadata_record.json_metadata) | |||
There was a problem hiding this comment.
we probably do want to add/update a test to cover this line.
Description
enterprise_force_include_aggregation_keysTodo