Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop include_exec_ed_2u_courses field #779

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

johnnagro
Copy link
Contributor

Description

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, should we publicly state we're removing the unique constraint from queries?

@@ -73,6 +73,7 @@ class CatalogQuery(TimeStampedModel):
null=True,
max_length=32,
editable=False,
unique=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bigger change that maybe we need to notify people about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unique before we added this column, we then made it unique together, since we're dropping the include column we can go back to just this column being unique

@alex-sheehan-edx alex-sheehan-edx merged commit 7dcf9fa into master Mar 4, 2024
6 checks passed
@alex-sheehan-edx alex-sheehan-edx deleted the johnnagro/ENT-7893/8 branch March 4, 2024 20:59
irfanuddinahmad pushed a commit that referenced this pull request Jul 24, 2024
feat: drop include_exec_ed_2u_courses field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants