feat: add utils to communicate with openai #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
from
d293ed6 to
2650b00
Compare
muhammad-ammar
commented
Mar 8, 2024
|
|
||
| if response_format == 'json': | ||
| try: | ||
| return simplejson.loads(response_content) |
There was a problem hiding this comment.
Note: Will refactor this to add a validation to check that if the json response is of expected type? For example, in our case, we expect list
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
2 times, most recently
from
e9690ea to
29d9948
Compare
muhammad-ammar
commented
Mar 8, 2024
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
2 times, most recently
from
69ec8d0 to
c5167a7
Compare
saleem-latif
approved these changes
Mar 11, 2024
| messages, | ||
| response | ||
| ) | ||
| raise InvalidJSONResponseError('Invalid JSON response received from chatgpt', dev_message=ex.message) |
There was a problem hiding this comment.
Can we make this error message more user friendly?
There was a problem hiding this comment.
This will be returned to the frontend, right?
There was a problem hiding this comment.
No. We will not send this to frontend.
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
from
1fac05e to
b9be8c5
Compare
saleem-latif
approved these changes
Mar 12, 2024
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
3 times, most recently
from
aa3bea2 to
f449ad4
Compare
muhammad-ammar
force-pushed
the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
from
f449ad4 to
70e7d65
Compare
muhammad-ammar
deleted the
ammar/ai-curation/ai-filtered-subjects-and-keywords
branch
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
…bjects-and-keywords feat: add utils to communicate with openai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add utils for ai curation
Ticket: https://2u-internal.atlassian.net/browse/ENT-8317
Post-review