Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort menu collapse after filter selection #645

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

sundasnoreen12
Copy link
Contributor

INF-1096

Description

Issue: If filter menu is lengthy, selecting an option does not seem to have any impact, as seen in attached screen recording. Users will need to scroll down or close the menu to see the impact.

Solution: To remedy that, the filter menu is now collapsible once an option has been selected.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5df51f2) 92.38% compared to head (f4b51ef) 92.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         169      169           
  Lines        3452     3452           
  Branches      892      892           
=======================================
  Hits         3189     3189           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayesha-waris ayesha-waris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@sundasnoreen12 sundasnoreen12 merged commit ffb3864 into master Jan 17, 2024
6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1096 branch January 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants