-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed eslint-disable statements #646
chore: removed eslint-disable statements #646
Conversation
Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
Thank you for this contribution, @sohailfatima! Please let me know if you have any questions regarding submitting the CLA form. Thanks! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 92.39% 92.76% +0.37%
==========================================
Files 169 156 -13
Lines 3456 3303 -153
Branches 896 902 +6
==========================================
- Hits 3193 3064 -129
+ Misses 243 219 -24
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove all the icon components and use these icons from paragon.
- Remove
eslint-disable no-param-reassig
disable eslint and update the code. - Remove all the index files that are just using for exporting one component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test Discussions MFE properly once again because this change is big. Other than this PR LGTM.
@sohailfatima Please rebase this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: few minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM. Please rebase with master
I'm closing this PR as @sohailfatima does not have the cla permission. We created a new PR for these Changes. 658 |
@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Removed all unnecessary / unintentional eslint-disable statements, refactoring the code accordingly. No changes have been made to the functionality.