Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed eslint-disable statements #646

Closed
wants to merge 10 commits into from
Closed

chore: removed eslint-disable statements #646

wants to merge 10 commits into from

Conversation

sohailfatima
Copy link
Contributor

@sohailfatima sohailfatima commented Jan 19, 2024

Description

Removed all unnecessary / unintentional eslint-disable statements, refactoring the code accordingly. No changes have been made to the functionality.

@openedx-webhooks
Copy link

Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 19, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 19, 2024
@mphilbrick211
Copy link

Thank you for this contribution, @sohailfatima! Please let me know if you have any questions regarding submitting the CLA form. Thanks!

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (88a985d) 92.39% compared to head (f4d7f3e) 92.76%.

Files Patch % Lines
src/discussions/posts/data/slices.js 78.12% 14 Missing ⚠️
src/discussions/post-comments/data/slices.js 95.65% 3 Missing ⚠️
...iscussions/post-comments/comments/CommentsView.jsx 85.71% 1 Missing and 1 partial ⚠️
src/discussions/data/slices.js 83.33% 1 Missing ⚠️
src/discussions/topics/data/slices.js 85.71% 1 Missing ⚠️
.../discussions/topics/topic-group/TopicGroupBase.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   92.39%   92.76%   +0.37%     
==========================================
  Files         169      156      -13     
  Lines        3456     3303     -153     
  Branches      896      902       +6     
==========================================
- Hits         3193     3064     -129     
+ Misses        243      219      -24     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove all the icon components and use these icons from paragon.
  2. Remove eslint-disable no-param-reassig disable eslint and update the code.
  3. Remove all the index files that are just using for exporting one component.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 22, 2024
Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test Discussions MFE properly once again because this change is big. Other than this PR LGTM.

@awais-ansari
Copy link
Contributor

@sohailfatima Please rebase this branch.

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: few minor changes

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM. Please rebase with master

@awais-ansari
Copy link
Contributor

I'm closing this PR as @sohailfatima does not have the cla permission. We created a new PR for these Changes. 658

@openedx-webhooks
Copy link

@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants