fix: broken skip link in Learner Dashboard

[Ankush1oo8]

Fixed issue #510
Learner Dashboard has a broken skip link

[openedx-webhooks]

Thanks for the pull request, @Ankush1oo8!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[jsnwesson]

This is looking much better, @Ankush1oo8 ! I did notice that one test that is failing is a lint where they want you to use double quotes instead of single quotes.

[Ankush1oo8]

This is looking much better, @Ankush1oo8 ! I did notice that one test that is failing is a lint where they want you to use double quotes instead of single quotes.

Changing it

[Ankush1oo8]

I have changed the single quotes to double quotes

[jsnwesson]

Great! Now it looks like some of the Snapshot tests need to be updated (according to failing tests).

In your remote branch, you should be able to see what tests are failing by running npm run test.
You'll see some Jest Snapshots failing, because you made a change to the App.

To fix those snapshots, you would run npm run snapshot

[Ankush1oo8]

I tried to run the commands you told its showing fedx scripts not found

[jsnwesson]

@Ankush1oo8 ah, you'll need to first run npm install to install the dependencies, which includes fedx-scripts, then you can run all of the other NPM scripts (ie. npm run lint, npm run test, npm run snapshot).

[Ankush1oo8]

@Ankush1oo8 ah, you'll need to first run npm install to install the dependencies, which includes fedx-scripts, then you can run all of the other NPM scripts (ie. npm run lint, npm run test, npm run snapshot).

I have installed all dependencies prior to running the commands

[jsnwesson]

@Ankush1oo8 that's weird. I pulled your PR to my local machine, and when I simply run npm run snapshot without doing any install, I see the error you must be getting.

Once I run npm install and then run npm run snapshot, it works perfectly as expected. To confirm, what command did you run to install the dependencies? And do you see a folder node_modules at the top of the Learner Dashboard directory? That would confirm that you installed the dependencies successfully, and fedx-scripts would be in there.

[Ankush1oo8]

First i have done npm install then other cmds

[jsnwesson]

@Ankush1oo8 and can you confirm that you see a folder node_modules at the top of the Learner Dashboard directory?

[Ankush1oo8]

@jsnwesson yes node modules folder is present

[jsnwesson]

Hey @Ankush1oo8 , hope you're well! I'm not sure what the problem could be for you, but I'd encourage you to look through the Open edX developer documentation to see if someone has found a similar problem and solution for it, or to look through the Open edX Slack space.

[itsjeyd]

@Ankush1oo8 Thank you for this contribution!

Just wanted to highlight that you'll need to submit a signed contributor agreement (CLA) at some point. There's no rush, but we can't merge this PR without that.

You can check this comment from the PR bot for details.

[Ankush1oo8]

@Ankush1oo8 Thank you for this contribution!

Just wanted to highlight that you'll need to submit a signed contributor agreement (CLA) at some point. There's no rush, but we can't merge this PR without that.

You can check this comment from the PR bot for details.

I have filled the form

[itsjeyd]

Thanks for the update @Ankush1oo8. It looks like the CLA check is still failing. Me posting this comment should rerun it. Let's see what happens.

[Ankush1oo8]

Should I update the branch

[Ankush1oo8]

I have tried to find the issue but can't find it

[Ankush1oo8]

Thanks

[itsjeyd]

Hey @openedx/cla-problems team, there seems to be a problem with the CLA check here. Author said they filled the CLA form a while ago, but the check is still failing. Could you please have a look?

[feanil]

@Ankush1oo8 @itsjeyd I can confirm that we have the CLA but it's in the middle of our approval process. Hopefully that will get approved soon, but you should not need to send it in again. In the mean time, it looks like there a NODE CI test failure that needs to be addressed.

[itsjeyd]

Thanks for the update @feanil!

@Ankush1oo8 While you're waiting, could you please have a look at the test failure and fix it?

[itsjeyd]

Posting this to test if it will fix the CLA check.

[itsjeyd]

@feanil Do you have any updates on whether @Ankush1oo8's CLA has been approved by now?

[feanil]

@itsjeyd still looking into it. There are parts of the process that are not clear to me so I've reached out to our legal team to figure out what's going on.

[itsjeyd]

Got it, thanks for the update @feanil.

[feanil]

@Ankush1oo8 I have an update on this. It looks like the form online was filled out but that generates a Docusign document that you must sign. That document would have gone to the email address that you provided when you filled out web form. ankush...wit@gmail.com is the e-mail it would have gone to.

FYI @itsjeyd

[Ankush1oo8]

@Ankush1oo8 I have an update on this. It looks like the form online was filled out but that generates a Docusign document that you must sign. That document would have gone to the email address that you provided when you filled out web form. ankush...wit@gmail.com is the e-mail it would have gone to.

FYI @itsjeyd

I did not receive it
I have again filled the form if needed

[feanil]

@Ankush1oo8, please go ahead and refill the form and please make sure the e-mail is correct.

[Ankush1oo8]

@Ankush1oo8, please go ahead and refill the form and please make sure the e-mail is correct.

Done

[Ankush1oo8]

@feanil have you got the doc

[feanil]

Yep, and the CLA is passing now! This should be good to get reviewed now!

[itsjeyd]

@Ankush1oo8 Congrats on the passing CLA check! :)

Have you had a chance to look into why the Node CI tests aren't passing?

[Ankush1oo8]

@Ankush1oo8 Congrats on the passing CLA check! :)

Have you had a chance to look into why the Node CI tests aren't passing?

I tried to look in the error but not able to do anything about it I tried to use lint fix but that did not work either.
If you can help please tell me what I can do.

[MaxFrank13]

@Ankush1oo8 Have you tried running npm test -- -u to update the snapshots?

[Ankush1oo8]

@MaxFrank13 yes done

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (e764e9c) to head (2a4d182).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files         155      155           
  Lines        1365     1365           
  Branches      229      229           
=======================================
  Hits         1329     1329           
  Misses         34       34           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MaxFrank13]

Okay just ran the workflows and it looks like that got passed the failing tests. Now you'll just need to clean up the commit messages using conventional commits

[MaxFrank13]

Talked with @jsnwesson and we decided we will be squashing the commits anyway so this is good to go! Thanks for the contribution @Ankush1oo8!

[Ankush1oo8]

@MaxFrank13 thanks