feat: make level type and primary subjects field optional for masters…

… courses
openedx · Feb 24, 2025 · 8e7d98d · 8e7d98d
1 parent 5c19a5c
commit 8e7d98d
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/components/EditCoursePage/EditCourseForm.jsx b/src/components/EditCoursePage/EditCourseForm.jsx
@@ -1007,7 +1007,7 @@ export class BaseEditCourseForm extends React.Component {
               extraInput={{ onInvalid: this.openCollapsible }}
               options={levelTypeOptions}
               disabled={disabled}
-              required={isSubmittingForReview}
+              required={showMarketingFields && isSubmittingForReview}
             />
             <Field
               name="subjectPrimary"
@@ -1040,7 +1040,7 @@ export class BaseEditCourseForm extends React.Component {
               extraInput={{ onInvalid: this.openCollapsible }}
               options={subjectOptions}
               disabled={disabled}
-              required={isSubmittingForReview}
+              required={showMarketingFields && isSubmittingForReview}
             />
             <Field
               name="subjectSecondary"

diff --git a/src/components/EditCoursePage/EditCourseForm.test.jsx b/src/components/EditCoursePage/EditCourseForm.test.jsx
@@ -494,4 +494,33 @@ describe('BaseEditCourseForm', () => {
     />);
     expect(shallowToJson(component)).toMatchSnapshot();
   });
+
+  it('does not add required prop for level_type and subjectPrimary fields when not submitting for review', () => {
+    const initialValuesWithMasters = {
+      ...initialValuesFull,
+      type: '7b41992e-f268-4331-8ba9-72acb0880454',
+    };
+
+    const component = shallow(<BaseEditCourseForm
+      handleSubmit={() => null}
+      title="Test Course"
+      initialValues={{ title: initialValuesFull.title }}
+      currentFormValues={initialValuesWithMasters}
+      number="Test101x"
+      courseStatuses={[UNPUBLISHED]}
+      courseInfo={courseInfo}
+      courseOptions={courseOptions}
+      courseRunOptions={courseRunOptions}
+      uuid={initialValuesWithMasters.uuid}
+      type={initialValuesWithMasters.type}
+      isSubmittingForReview={false}
+      id="edit-course-form"
+    />);
+
+    const levelTypeField = component.find(Field).filterWhere(n => n.prop('name') === 'level_type');
+    const subjectPrimaryField = component.find(Field).filterWhere(n => n.prop('name') === 'subjectPrimary');
+
+    expect(levelTypeField.prop('required')).toBe(false);
+    expect(subjectPrimaryField.prop('required')).toBe(false);
+  });
 });