feat: make level type and subjects field optional for masters courses #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
from
adbfeec to
6b58c8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
==========================================
+ Coverage 68.04% 68.06% +0.01%
==========================================
Files 129 129
Lines 3248 3250 +2
Branches 943 946 +3
==========================================
+ Hits 2210 2212 +2
+ Misses 993 990 -3
- Partials 45 48 +3 ☔ View full report in Codecov by Sentry. |
|
Instead of hiding the fields altogether, make them optional in case some teams want to add the values. |
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
2 times, most recently
from
1f71a58 to
67f792c
Compare
| @@ -1007,7 +1007,7 @@ export class BaseEditCourseForm extends React.Component { | |||
| extraInput={{ onInvalid: this.openCollapsible }} | |||
| options={levelTypeOptions} | |||
| disabled={disabled} | |||
| required={isSubmittingForReview} | |||
| required={isSubmittingForReview && showMarketingFields} | |||
There was a problem hiding this comment.
please add appropriate unit tests.
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
from
67f792c to
bd6131a
Compare
Ali-D-Akbar
changed the title
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
3 times, most recently
from
1e66a94 to
2bdab04
Compare
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
from
2bdab04 to
8e7d98d
Compare
DawoudSheraz
approved these changes
Feb 25, 2025
AfaqShuaib09
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3254
This PR puts Level Type and Primary Subject as non-marketable fields i.e. make them optional for masters courses (and all the non-marketable courses)