Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define displayName for all components with forwarded refs #3460

Open
wants to merge 1 commit into
base: release-22.x
Choose a base branch
from

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Mar 6, 2025

Description

https://legacy.reactjs.org/docs/forwarding-refs.html#displaying-a-custom-name-in-devtools

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit 874ee80
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/67c9a2743067e200086fa92c
😎 Deploy Preview https://deploy-preview-3460--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.53%. Comparing base (0077397) to head (874ee80).

Files with missing lines Patch % Lines
src/Dropdown/index.jsx 97.14% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-22.x    #3460      +/-   ##
================================================
+ Coverage         93.46%   93.53%   +0.06%     
================================================
  Files               252      252              
  Lines              4543     4591      +48     
  Branches           1023     1023              
================================================
+ Hits               4246     4294      +48     
  Misses              294      294              
  Partials              3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant