Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ramping up write API requests #465

Merged
merged 2 commits into from
Mar 24, 2025
Merged

feat: support ramping up write API requests #465

merged 2 commits into from
Mar 24, 2025

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Mar 10, 2025

Description

On fga tuple write we now support the following flags: --max-rps and --rampup-period-in-sec. If one is set, both are required.

e.g. --max-rps 10 --rampup-period-in-sec 10

If these flags are set the CLI will start ramping up requests from 1RPS to the configured max RPS over the configured period

References

closes #463

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Sorry, something went wrong.

Copy link

stacklok-cloud bot commented Mar 10, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 52abcf46:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@rhamzeh rhamzeh marked this pull request as ready for review March 21, 2025 13:05
@rhamzeh rhamzeh requested a review from a team as a code owner March 21, 2025 13:05
@rhamzeh rhamzeh requested review from a team as code owners March 24, 2025 19:52
@rhamzeh rhamzeh added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit dd24e16 Mar 24, 2025
17 checks passed
@rhamzeh rhamzeh deleted the feat/ramp-up branch March 24, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying RPS for Writes while allowing for ramp up over a period of time
2 participants