Fix new relic redis configuration #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default New Relic monitor the redis instance running on port 6379. We are interested in monitoring the cache instance of redis, running on port 6380. This add a task to update the port to 6380.
dacook
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Nice. Is it possible to monitor multiple instances? We also use it for sidekiq (https://github.com/openfoodfoundation/ofn-install/blob/master/inventory/group_vars/all.yml#L75-L76), so it would be good to monitor that also.
playbooks/provision.yml
Outdated
Comment on lines
125
to
126
| regexp: '^(\s*PORT:)\s6379$' | ||
| replace: '\1 6380' |
There was a problem hiding this comment.
This should work, but it assumes although it's worth noting that if the port was set to anything else, it would silently skip over and do nothing. I'm not sure how to improve it though.
dacook
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Unfortunately it doesn't work in CI:
https://github.com/openfoodfoundation/ofn-install/actions/runs/12270155766/job/34234930102
TASK [update new relic redis configuration] ************************************
fatal: [local_test]: FAILED! => {
"changed": false,
"rc": 257
}
MSG:
Path /etc/newrelic-infra/integrations.d/redis-config.yml does not exist !
It will now monitor all three intances, and they are tags with their role.
dacook
requested changes
Jan 13, 2025
- update metrics every minute - update inventory daily
mkllnk
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-closes #922
By default New Relic monitor the redis instance running on port 6379. We are interested in monitoring the cache instance of redis, running on port 6380. This add a task to update the port to 6380.Once merged, we'll need to update all the server (Will track that on #922 ) . You can use the following command :By default New Relic monitor the redis instance running on port 6379. We are running three instances on port 6379,6380 and 6381. This change will add monitoring for all instances, and they get tagged with their role.
Once merged, we'll need to update all the server (Will track that on #922 ) . You can use the following command :