Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect typ in proof type example #134

Closed
jogu opened this issue Dec 8, 2023 · 2 comments · Fixed by #128
Closed

incorrect typ in proof type example #134

jogu opened this issue Dec 8, 2023 · 2 comments · Fixed by #128

Comments

@jogu
Copy link
Contributor

jogu commented Dec 8, 2023

The example proof jwt in https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-7.2.1.1
has "typ": "JWT" in the header, I think it should be "openid4vci-proof+jwt," as per https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#jwt-proof-type
@jogu jogu mentioned this issue Dec 8, 2023
Merged
@selfissued
Copy link
Member

I agree. I could add this fix to PR #144 if people want me to.

@Sakurann
Copy link
Collaborator

fixing this in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add sd-jwt vc profile to vci openid/OpenID4VCI
3 participants
@jogu @selfissued @Sakurann