add sd-jwt vc profile to vci #128

Sakurann · 2023-12-07T01:45:36Z

resolves #122. resolves #28. resolves #134

peppelinux

Some small editorials to join. In the meantime I approve this PR.

openid-4-verifiable-credential-issuance-1_0.md

examples/credential_request_sd_jwt_vc.json

openid-4-verifiable-credential-issuance-1_0.md

examples/client_metadata_sd_jwt_vc.json

examples/credential_request_sd_jwt_vc.json

Co-authored-by: Joseph Heenan <joseph@heenan.me.uk> Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>

Co-authored-by: Paul Bastian <paul.bastian@posteo.de>

… sd-jwt-vc

openid-4-verifiable-credential-issuance-1_0.md

examples/credential_request_sd_jwt_vc.json

examples/credential_metadata_sd_jwt_vc.json

examples/authorization_details_sd_jwt_vc.json

examples/credential_request_sd_jwt_vc.json

openid-4-verifiable-credential-issuance-1_0.md

awoie

Please use the ISO mdoc section as a basis for SD-JWT VC and just replace doctype with vct.

openid-4-verifiable-credential-issuance-1_0.md

TimoGlastra

As having implemented SD-JWT in OpenID4VC but not HAIP, I like the sd-jwt format profile being moved to OID4VCI

Co-authored-by: Oliver Terbu <43441584+awoie@users.noreply.github.com> Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>

… sd-jwt-vc

examples/credential_metadata_sd_jwt_vc.json

openid-4-verifiable-credential-issuance-1_0.md

Sakurann · 2023-12-14T17:14:27Z

@TimoGlastra just the heads up that if you implemented sd-jwt vc profile that was in HAIP, this PR introduces breaking changes to that.

tplooker · 2023-12-18T02:42:13Z

openid-4-verifiable-credential-issuance-1_0.md

+
+The following additional parameters are defined for Credential Requests and this Credential format.
+
+* `vct`: REQUIRED when the `credential_identifier` is not used. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.


Do we need to clearer about when VCT and credential_identifier are both present in a credential request? Does one need to take precedent, what if they conflict?

If we do, I think it should be clarified when addressing issue #132.

the clarification should also be in this section that defines the behavior of credential request https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#name-credential-request, so this is probably out of scope of this PR.

the current thinking has been that both format specific claims and credential_identifier can be present since it is possible to use both scopes and RAR in the same authz request

I cannot think of any case where both, the credential_identifier and the vct could be in the same request, so this should be a MUST NOT if credential_identifier is present.

The credential request text already states "When this parameter is used, the format parameter and any other Credential format specific set of parameters such as those defined in (#format_profiles) MUST NOT be present."

Additionally, I'm not sure these requirements should be stated in a profile as the interplay between credential_identifier and format+format specific type information is subject to the core spec. I think the profile should state something like: "vct: determines the type of a credential of this format, might also be used in credential request ..."

Right. I confused the ability to use both for the same credential - we still currently support using RAR for one credential and format/type for another with the same access token.

This came up because 'vct' is mandatory when format/type is used but must not be present when credential_identifier is used. So honestly, I would suggest that current language works ok.

Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>

tlodderstedt · 2023-12-18T17:49:00Z

openid-4-verifiable-credential-issuance-1_0.md

+
+The following additional parameters are defined for Credential Requests and this Credential format.
+
+* `vct`: REQUIRED when the `credential_identifier` is not used. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.


Suggested change

* `vct`: REQUIRED when the `credential_identifier` is not used. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.

* `vct`: String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer. This claim MUST NOT be present if the `credential_identifier` is present in the request.

I clarified for all other credential formats, too.

…wt-vc

tlodderstedt

we are almost there ;-)

openid-4-verifiable-credential-issuance-1_0.md

tlodderstedt · 2023-12-21T14:05:46Z

openid-4-verifiable-credential-issuance-1_0.md

+
+The following additional parameters are defined for Credential Requests and this Credential format.
+
+* `vct`: REQUIRED when the `credential_identifier` was not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.


Suggested change

* `vct`: REQUIRED when the `credential_identifier` was not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.

* `vct`: REQUIRED when the `credential_identifier` is not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.

tlodderstedt · 2023-12-21T14:06:02Z

openid-4-verifiable-credential-issuance-1_0.md

+
+The following additional parameters are defined for Credential Requests and this Credential format.
+
+* `vct`: REQUIRED when the `credential_identifier` was not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.


Suggested change

* `vct`: REQUIRED when the `credential_identifier` was not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.

* `vct`: REQUIRED when the `credential_identifier` was not present in the Credential Request. MUST NOT be used otherwise. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type value of the Credential the Wallet requests the Credential Issuer to issue.

awoie · 2023-12-21T14:53:33Z

openid-4-verifiable-credential-issuance-1_0.md

+
+### Credential Issuer Metadata {#server_metadata_sd_jwt_vc}
+
+The following additional Credential Issuer metadata parameters are defined for this Credential format to be added to the `credentials_supported` parameter in addition to those defined in (#credential-issuer-parameters).


This will conflict with with the credential_configurations_supported change.

openid-4-verifiable-credential-issuance-1_0.md

Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>

add sd-jwt vc profile to vci

907df86

Sakurann requested review from bifurcation, danielfett, jogu, tlodderstedt, pmhsfelix, peppelinux, c2bo, awoie, bc-pi, selfissued and tplooker December 7, 2023 01:45

Sakurann added this to the ID-1 milestone Dec 7, 2023

paulbastian approved these changes Dec 7, 2023

View reviewed changes

peppelinux approved these changes Dec 7, 2023

View reviewed changes

c2bo reviewed Dec 7, 2023

View reviewed changes

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved

c2bo approved these changes Dec 7, 2023

View reviewed changes

jogu requested changes Dec 7, 2023

View reviewed changes

paulbastian reviewed Dec 7, 2023

View reviewed changes

examples/credential_request_sd_jwt_vc.json Outdated Show resolved Hide resolved

Sakurann and others added 4 commits December 7, 2023 08:38

Apply suggestions from code review

5445eed

Co-authored-by: Joseph Heenan <joseph@heenan.me.uk> Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>

fixing a jwt example

2f7293d

Co-authored-by: Paul Bastian <paul.bastian@posteo.de>

remove client metadata and add credential metadata

7edba46

Merge branch 'sd-jwt-vc' of https://github.com/openid/OpenID4VCI into…

ab1e2d2

… sd-jwt-vc

Sakurann requested a review from jogu December 7, 2023 23:57

jogu reviewed Dec 8, 2023

View reviewed changes

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved

awoie requested changes Dec 11, 2023

View reviewed changes

TimoGlastra approved these changes Dec 11, 2023

View reviewed changes

Sakurann and others added 2 commits December 11, 2023 14:56

Apply suggestions from code review

a08908e

Co-authored-by: Oliver Terbu <43441584+awoie@users.noreply.github.com> Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>

restructure issuer metadata

a4f63a7

Kristina added 2 commits December 13, 2023 16:33

update requirements

b678b63

Merge branch 'sd-jwt-vc' of https://github.com/openid/OpenID4VCI into…

c62c29b

… sd-jwt-vc

Sakurann requested a review from tlodderstedt December 14, 2023 00:36

bc-pi reviewed Dec 14, 2023

View reviewed changes

examples/credential_metadata_sd_jwt_vc.json Outdated Show resolved Hide resolved

Update examples/credential_metadata_sd_jwt_vc.json

6d61d61

Sakurann commented Dec 14, 2023

View reviewed changes

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved

tplooker reviewed Dec 18, 2023

View reviewed changes

TimoGlastra mentioned this pull request Dec 18, 2023

feat: add sd-jwt issuer support and e2e test Sphereon-Opensource/OID4VC#80

Merged

Sakurann mentioned this pull request Dec 18, 2023

Move Appendix E #157

Closed

Update openid-4-verifiable-credential-issuance-1_0.md

9d7fdd8

Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>

tlodderstedt requested changes Dec 18, 2023

View reviewed changes

awoie self-requested a review December 19, 2023 20:39

tplooker self-requested a review December 19, 2023 20:39

Kristina added 2 commits December 20, 2023 17:02

Merge branch 'main' of https://github.com/openid/OpenID4VCI into sd-j…

b0b5d5f

…wt-vc

clarify when the type must be present

79dfddc

Sakurann requested a review from tlodderstedt December 21, 2023 01:08

make sure proof jwt is well-formed (issue 134)

a2dd7d0

Sakurann mentioned this pull request Dec 21, 2023

incorrect typ in proof type example #134

Closed

jogu self-requested a review December 21, 2023 09:57

jogu approved these changes Dec 21, 2023

View reviewed changes

tlodderstedt requested changes Dec 21, 2023

View reviewed changes

awoie approved these changes Dec 21, 2023

View reviewed changes

Sakurann commented Dec 21, 2023

View reviewed changes

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved

Apply suggestions from torsten's code review

f8b0d45

Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>

tlodderstedt approved these changes Dec 21, 2023

View reviewed changes

Sakurann merged commit 1bb7b84 into main Dec 21, 2023
2 checks passed

TimoGlastra mentioned this pull request Dec 22, 2023

Add vc+sd-jwt format decentralized-identity/claim-format-registry#7

Open

Sakurann mentioned this pull request Feb 14, 2024

Add SD-JWT VC Profile openid/OpenID4VP#74

Closed

danielfett mentioned this pull request Feb 19, 2024

Incomplete definition of mandatory in SD-JWT VC claim metadata #272

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add sd-jwt vc profile to vci #128

add sd-jwt vc profile to vci #128

Sakurann commented Dec 7, 2023 •

edited

Loading

peppelinux left a comment

awoie left a comment

TimoGlastra left a comment •

edited

Loading

Sakurann commented Dec 14, 2023

tplooker Dec 18, 2023

Sakurann Dec 18, 2023

tlodderstedt Dec 18, 2023

Sakurann Dec 18, 2023

tlodderstedt Dec 18, 2023

Sakurann Dec 21, 2023

tlodderstedt left a comment

tlodderstedt Dec 21, 2023

tlodderstedt Dec 21, 2023

awoie Dec 21, 2023

Sakurann Dec 21, 2023


		The following additional parameters are defined for Credential Requests and this Credential format.

		* `vct`: REQUIRED when the `credential_identifier` is not used. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.

	* `vct`: REQUIRED when the `credential_identifier` is not used. String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer.
	* `vct`: String as defined in (#server_metadata_sd_jwt_vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer. This claim MUST NOT be present if the `credential_identifier` is present in the request.


		### Credential Issuer Metadata {#server_metadata_sd_jwt_vc}

		The following additional Credential Issuer metadata parameters are defined for this Credential format to be added to the `credentials_supported` parameter in addition to those defined in (#credential-issuer-parameters).

add sd-jwt vc profile to vci #128

add sd-jwt vc profile to vci #128

Conversation

Sakurann commented Dec 7, 2023 • edited Loading

peppelinux left a comment

Choose a reason for hiding this comment

awoie left a comment

Choose a reason for hiding this comment

TimoGlastra left a comment • edited Loading

Choose a reason for hiding this comment

Sakurann commented Dec 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlodderstedt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakurann commented Dec 7, 2023 •

edited

Loading

TimoGlastra left a comment •

edited

Loading