rename to credential_dataset_identifier #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
danielfett,
jogu,
tlodderstedt,
selfissued and
paulbastian
jogu
approved these changes
Nov 7, 2023
peppelinux
reviewed
Nov 7, 2023
paulbastian
approved these changes
Nov 14, 2023
pmhsfelix
approved these changes
Nov 16, 2023
|
This is not making into the spec before ID-1 because we decided we need to more time to flesh out Batch issuance. Really not sure this breaking change will be worth it after ID-1. closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per discussion in #91 (comment)
renaming the identifier introduced in PR #65 from credential_identifier to credential_metadata_identifier and thereby addressing the remaining naming bikeshedding topic that we agreed to keep discussing when merging PR #65.
This PR should go hand in hand with @danielfett 's PR on three different layers of credentials: credential definition (format, type, display, etc.), credential dataset (same credential definition with a specific claimset/claim values), credential instance (copies of credential dataset)