-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove credential offer part from credential profiles #121
Conversation
When paul did a previous PR, I suggested not to remove entirely to show concrete examples how to use credential format specific identifiers, etc.. |
I don't have strong opinions on this I think having more than one example is nice and the credential offer in appendix could match to the credential issuer metadata. Especially having some examples for the changes in #95 would be nice. On the other hand, we don't have examples on e.g. authroization response either and we could move some examples to the credential offer section if we want more examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came along with this.
but as @jogu said during the WG call, would like to see the example files unused elsewhere in the spec removed before we merge this.
also it does not compile as-is..
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
I think it would be good to include at least one of the existing examples into the credential offer section, to see some variations of transaction code |
I did some changes, please review |
After the recent changes, there is no longer any format specific part in a credential offer. This PR removes the respective definitions from the credential format profiles.