Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language around opening Credential Offer Endpoint #380

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Clarify language around opening Credential Offer Endpoint #380

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
899c512
Clarify language around opening Credential Offer Endpoint
jogu Aug 25, 2024
02adeb4
resource owner -> End-User
jogu Sep 10, 2024
03fadd4
Reorder credential offer section slightly
jogu Sep 10, 2024
30c0bca
Modified based on feedback on the PR
jogu Sep 10, 2024
44d673c
Add that direct communication of offers to wallet backend is possible
jogu Oct 4, 2024
2b1fdf4
Apply Kristina's suggestion
jogu Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openid-4-verifiable-credential-issuance-1_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,9 @@ This endpoint is used by a Credential Issuer that is already interacting with an

## Credential Offer {#credential-offer}

The Credential Issuer sends Credential Offer using an HTTP GET request or an HTTP redirect to the Wallet's Credential Offer Endpoint defined in (#client-metadata).
The Credential Issuer makes a Credential Offer by allowing the End-User to invoke the Wallet using the Wallet's Credential Offer Endpoint defined in (#client-metadata) (for example by clicking a link) and/or rendering a QR code containing the Credential Offer that the End-User can scan in a wallet or an arbitrary camera application.
jogu marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about custom url schemes as clickable links?

Copy link
Contributor Author

@jogu jogu Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case the "Wallet's Credential Offer Endpoint" is a custom scheme url, I think that case is covered?

nemqe marked this conversation as resolved.
Show resolved Hide resolved

Credential Issuers MAY also communicate Credential Offers directly to a Wallet's backend but any mechanism for doing so is currently outside the scope of this specification.

The Credential Offer object, which is a JSON-encoded object with the Credential Offer parameters, can be sent by value or by reference.

Expand All @@ -342,8 +344,6 @@ The Credential Offer contains a single URI query parameter, either `credential_o
* `credential_offer`: Object with the Credential Offer parameters. This MUST NOT be present when the `credential_offer_uri` parameter is present.
* `credential_offer_uri`: String that is a URL using the `https` scheme referencing a resource containing a JSON object with the Credential Offer parameters. This MUST NOT be present when the `credential_offer` parameter is present.

The Credential Issuer MAY render a QR code containing the Credential Offer that can be scanned by the End-User using a Wallet, or a link that the End-User can click.

For security considerations, see (#credential-offer-security).

### Credential Offer Parameters {#credential-offer-parameters}
Expand Down