-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate proof parameter #453
Conversation
Dear @c2bo IMHO, that's a reasonable choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great - thank you
Co-authored-by: Joseph Heenan <joseph@authlete.com>
Closes #345
Removes the
proof
parameter in favour of always usingproofs
.One point I wasn't sure about: To make the
proofs
object easier to parse , it always contains a parameter (named after the proof type) that contains a non-empty array. This means that for proofs of the typeattestation
, it contains an array containing exactly one JWT proof.Are people fine with that choice?