Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate proof parameter #453

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Deprecate proof parameter #453

merged 5 commits into from
Feb 13, 2025

Conversation

c2bo
Copy link
Member

@c2bo c2bo commented Jan 29, 2025

Closes #345

Removes the proof parameter in favour of always using proofs.

One point I wasn't sure about: To make the proofs object easier to parse , it always contains a parameter (named after the proof type) that contains a non-empty array. This means that for proofs of the type attestation, it contains an array containing exactly one JWT proof.

Are people fine with that choice?

@babisRoutis
Copy link
Contributor

One point I wasn't sure about: To make the proofs object easier to parse , it always contains a parameter (named after the proof type) that contains a non-empty array. This means that for proofs of the type attestation, it contains an array containing exactly one JWT proof.

Are people fine with that choice?

Dear @c2bo

IMHO, that's a reasonable choice.

Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great - thank you

Co-authored-by: Joseph Heenan <joseph@authlete.com>
@Sakurann Sakurann merged commit 4a6b686 into main Feb 13, 2025
2 checks passed
@Sakurann Sakurann added this to the Final 1.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate usage of the 'proof' parameter in the credential request
6 participants