wallet-attestation+jwt media registry entry #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add the media type wallet-attestation+jwt in the media registry of this specification. It cames from [OpenID HAIP](openid/oid4vc-haip#86 (comment)) as it was asked me to move it to openid4vci.
peppelinux
requested review from
tlodderstedt,
jogu,
selfissued,
c2bo,
tplooker,
paulbastian,
awoie,
Sakurann and
bc-pi
Sakurann
approved these changes
Jan 31, 2025
paulbastian
requested changes
Jan 31, 2025
There was a problem hiding this comment.
https://drafts.oauth.net/draft-ietf-oauth-attestation-based-client-auth/draft-ietf-oauth-attestation-based-client-auth.html#name-client-attestation-jwt currently defines oauth-client-attestation+jwt, are we sure it makes sense to define something new here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the media type wallet-attestation+jwt in the media registry of this specification.
It cames from OpenID HAIP as it was asked me to move it to openid4vci.