-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data integrity verifiable presentation as proof of possession #66
add data integrity verifiable presentation as proof of possession #66
Conversation
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
For the use case of proof of possession i actually advocate removing the version number 2.0 One verifying a ldp_vp should both be capable of verifying a 1.0 as well as a 2.0 depending on the referenced context. Especially bearing in mind that the data model only changed slightly and the general form of the presentation remains the same. Most libraries already are capable of treating both versions at the same time. This naming is also more consistent with with the rest of the spec, where all DI-Proof credentials are typed as |
Co-authored-by: Gabe <7622243+decentralgabe@users.noreply.github.com>
Co-authored-by: Gabe <7622243+decentralgabe@users.noreply.github.com>
+1 to keeping |
@dlongley does the mechanism described in the PR looks good to you? would appreciate an approval/request for changes. |
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a few comments, one a minor clean up and the other a comment on language used in specs (generally) around "proof of possession" that promises / requires more than is technically possible.
Yes, approved -- with a couple of minor suggestions. This would be very helpful, thanks! |
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example needs to be moved to an appropriate section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concrete changes suggested
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. approving assuming my one suggestion will be accepted
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
@F-Node-Karlsruhe thank you for the PR and working with us. apologies it took the wg a while to merge this! |
@F-Node-Karlsruhe what name can I use to add you to the contributors in the acknowledgements section of the specificaiton? |
Christian Fries - European EPC Competence Center https://www.researchgate.net/profile/Christian_Fries4 thank you for mentioning me :) |
editorial. two approvals. per #66 (comment)
Added a linked data proof type for the proof of possession in the OID4VCI flow
Original PR: https://bitbucket.org/openid/connect/pull-requests/487/add-ldp_vp-as-proof-of-possession