Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348597: Update HarfBuzz to 10.4.0 #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

honkar-jdk
Copy link

@honkar-jdk honkar-jdk commented Mar 12, 2025

Hi all,

This pull request contains a backport of commit dbdbbd47 from the openjdk/jdk repository.

The commit being backported was authored by Harshitha Onkar on 10 Mar 2025 and was reviewed by Erik Joelsson and Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8348597 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348597: Update HarfBuzz to 10.4.0 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/132/head:pull/132
$ git checkout pull/132

Update a local copy of the PR:
$ git checkout pull/132
$ git pull https://git.openjdk.org/jdk24u.git pull/132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 132

View PR using the GUI difftool:
$ git pr show -t 132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/132.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport dbdbbd473061d7e8077ed07ccc6b03065a8c2ffc 8348597: Update HarfBuzz to 10.4.0 Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

⚠️ @honkar-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2025

Webrevs

@honkar-jdk
Copy link
Author

/approval request

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@honkar-jdk
8348597: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant