-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341767: [lworld] JIT support for nullable, atomic, flat arrays #1397
Conversation
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
Going to push as commit a0b174f4cf8166c5eff9c718045b5d3987c5e65c.
Your commit was automatically rebased without conflicts. |
@TobiHartmann Pushed as commit a0b174f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
C1 and C2 support for the new nullable, atomic, flat arrays (see JDK-8345995 for runtime). Follow-up work will be done with JDK-8350865 and is marked with
// TODO 8350865
in the code. Most complexity is in C2 due to the additional runtime checks and the conversion between scalarized values and atomic accesses.Thanks,
Tobias
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1397/head:pull/1397
$ git checkout pull/1397
Update a local copy of the PR:
$ git checkout pull/1397
$ git pull https://git.openjdk.org/valhalla.git pull/1397/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1397
View PR using the GUI difftool:
$ git pr show -t 1397
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1397.diff
Using Webrev
Link to Webrev Comment