Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341767: [lworld] JIT support for nullable, atomic, flat arrays #1397

Closed
wants to merge 31 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 13, 2025

C1 and C2 support for the new nullable, atomic, flat arrays (see JDK-8345995 for runtime). Follow-up work will be done with JDK-8350865 and is marked with // TODO 8350865 in the code. Most complexity is in C2 due to the additional runtime checks and the conversion between scalarized values and atomic accesses.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8341767: [lworld] JIT support for nullable, atomic, flat arrays (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1397/head:pull/1397
$ git checkout pull/1397

Update a local copy of the PR:
$ git checkout pull/1397
$ git pull https://git.openjdk.org/valhalla.git pull/1397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1397

View PR using the GUI difftool:
$ git pr show -t 1397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1397.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341767: [lworld] JIT support for nullable, atomic, flat arrays

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 6488ace: 8351951: [lworld] javac should issue an error if a strict instance field has not been initialized before the super invocation

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8341767 [lworld] JIT support for nullable, atomic, flat arrays 8341767: [lworld] JIT support for nullable, atomic, flat arrays Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 14, 2025

⚠️ @TobiHartmann This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@TobiHartmann TobiHartmann marked this pull request as ready for review March 14, 2025 13:55
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2025

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

Going to push as commit a0b174f4cf8166c5eff9c718045b5d3987c5e65c.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 6488ace: 8351951: [lworld] javac should issue an error if a strict instance field has not been initialized before the super invocation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 14, 2025
@openjdk openjdk bot closed this Mar 14, 2025
@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@TobiHartmann Pushed as commit a0b174f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant