Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid Random State and Other Test Bug #1362

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

LennartPurucker
Copy link
Contributor

See last failure of tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (d3bb775) to head (44b36a2).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1362      +/-   ##
===========================================
+ Coverage    84.07%   84.14%   +0.07%     
===========================================
  Files           38       38              
  Lines         5305     5305              
===========================================
+ Hits          4460     4464       +4     
+ Misses         845      841       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddiebergman
Copy link
Collaborator

I had to kill the windows runner as it was running for over 40 minutes without stopping. This seems to happen occasionally, will re-run failed jobs now

Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming no more sporadic test failures show up

@LennartPurucker LennartPurucker changed the title Fix Random State Bound Bug fix: Avoid Random State and Other Test Bug Oct 15, 2024
@LennartPurucker LennartPurucker merged commit 1dc97eb into develop Oct 15, 2024
11 of 13 checks passed
@LennartPurucker LennartPurucker deleted the LennartPurucker-patch-2 branch October 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants