Fixes readyness of textured quad2d metal instance

[zimmermannubique]

• "ready" nicht selber setzen, sonst wird setup() nicht komplett aufgerufen und das frame ist nicht gesetzt
• Wwenn instanceCount = 0 ist, gibt es einen Crash beim Erstellen darum ">=" zu ">"

Summary by CodeRabbit

• Bug Fixes
  • Improved the buffer creation process in the graphics module for better performance.
  • Fixed an issue with texture initialization in the Quad2d model, enhancing stability.

[coderabbitai]

Walkthrough

The modifications involve refining conditions and initialization logic within an iOS graphics application. Specifically, the update corrects a condition to ensure buffer creation occurs only when necessary, and tweaks the initialization of a quad instance by removing an unnecessary flag assignment related to texture setup, streamlining the process.

Changes

File Path	Change Summary
ios/graphics/.../MTLDevice+Helpers.swift	Modified condition in makeBuffer to require elementCount > 0
ios/graphics/.../Quad/Quad2dInstanced.swift	Removed ready flag assignment within lock.withCritical for texture initialization

🐇✨
In the realm of code, where the graphics play,
A rabbit hopped through, refining the way.
"No more shall we wait, when nothing's to show,
And textures shall load, as swiftly as flow."
With a hop and a skip, the changes were cast,
Ensuring the graphics, were perfectly fast.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 71b1f20 and 25f51f1.

Files selected for processing (2)

• ios/graphics/Helpers/MTLDevice+Helpers.swift (1 hunks)
• ios/graphics/Model/Quad/Quad2dInstanced.swift (1 hunks)

Additional comments: 1

ios/graphics/Helpers/MTLDevice+Helpers.swift (1)

• 18-18: The modification of the condition in the makeBuffer function from >= to > is a straightforward and effective solution to prevent crashes when sharedBytes.elementCount is 0. This change aligns with the PR objectives and enhances the stability of the application by ensuring that buffers are only created when there is at least one element to be rendered.