Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPORT-906: Corrected order of fetching report requests #254

Merged
merged 1 commit into from
Jan 31, 2025
Merged

REPORT-906: Corrected order of fetching report requests #254

merged 1 commit into from
Jan 31, 2025

Conversation

druchniewicz
Copy link
Contributor

No description provided.

@druchniewicz
Copy link
Contributor Author

@mseaton I've corrected order of fetching report requests - to take 'requestDate' as a first order priority. I've noticed that when e.g. report request is FAILED (because of e.g. broken sql data set) then evaluation_complete_datetime is NULL and those records are fetched later - what can be confusing because you've requested the report at the moment.

@mseaton
Copy link
Member

mseaton commented Jan 31, 2025

Looks fine @druchniewicz - happy to merge, but please either reference an existing ticket or create a new ticket to track this work and put the ticket number in the PR / commit message

@druchniewicz druchniewicz changed the title Corrected order of fetching report requests REPORT-906: Corrected order of fetching report requests Jan 31, 2025
@druchniewicz
Copy link
Contributor Author

Looks fine @druchniewicz - happy to merge, but please either reference an existing ticket or create a new ticket to track this work and put the ticket number in the PR / commit message

@mseaton right, I've corrected it

@mseaton mseaton merged commit dee614f into openmrs:master Jan 31, 2025
@druchniewicz
Copy link
Contributor Author

@mseaton thanks Michael for merging! Can you also take a look at this small PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@druchniewicz @mseaton