Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spatial decomposition #175

Closed
wants to merge 5 commits into from

Conversation

scottgigante-immunai
Copy link
Collaborator

Describe your changes

Add "spatial decomposition" task from v1. This is a draft PR because I want to check I've done this part right before I move on to the next part. @rcannood can you please take a look?

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would it make sense to create a component for generating a README based on the API files you created? If some of them are formatted wrong, the component can throw an error.

Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
@scottgigante-immunai
Copy link
Collaborator Author

Thanks! Yes, I think it makes sense to create two components here -- one that generates the sample API yaml files in #170 and a second that, given a completed API, checks the formatting and generates a README.

@scottgigante-immunai
Copy link
Collaborator Author

Perhaps that component could also paste the task info from task_info.yaml into the README for a more readable github repo?

@rcannood
Copy link
Member

If you merge the main branch into this one, you should be able to generate a task readme by running viash run src/common/create_task_readme/config.vsh.yaml -- --task spatial_decomposition :) (Added in #182)

The create_task_readme doesn't really validate the task API files, but the json schema files that were added in #183 will help in making sure that the format is correct.

@rcannood
Copy link
Member

Closing this PR since it's included in #283.

@rcannood rcannood closed this Nov 24, 2023
@rcannood rcannood deleted the scottgigante/spatial_decomposition branch April 22, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants