-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spatial decomposition #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would it make sense to create a component for generating a README based on the API files you created? If some of them are formatted wrong, the component can throw an error.
Thanks! Yes, I think it makes sense to create two components here -- one that generates the sample API yaml files in #170 and a second that, given a completed API, checks the formatting and generates a README. |
Perhaps that component could also paste the task info from task_info.yaml into the README for a more readable github repo? |
If you merge the main branch into this one, you should be able to generate a task readme by running viash run The |
Closing this PR since it's included in #283. |
Describe your changes
Add "spatial decomposition" task from v1. This is a draft PR because I want to check I've done this part right before I move on to the next part. @rcannood can you please take a look?
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!