FIX: notebooks (#69)

* fix baltrad2wradlib.ipynb
* fix baltrad drqc notebook
* fix baltrad pyart notebook
* fix baltrad pyart test assertions
* pre-commit run --all-files
* remove baltrad install files from image
* tag with pr number
* pin xradar>=0.6.3
* add pydda to root-env, remove stale nightly-build.yaml

.github/workflows/build-book-pullrequest.yaml

@@ -28,7 +28,7 @@ permissions:
   contents: read
 
 env:
-  DOCKER_TAG: pr_65
+  DOCKER_TAG: pr_69
 
 jobs:
   build-book:

.github/workflows/build-book.yaml

@@ -25,7 +25,7 @@ on:
         type: string  # had a lot of trouble with boolean types, see https://github.com/actions/runner/issues/1483
 
 env:
-  DOCKER_TAG: pr_65
+  DOCKER_TAG: pr_69
 
 jobs:
   build-container:

.github/workflows/deploy-book.yaml

@@ -39,4 +39,4 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: _build/html
-          keep_files: true  # This preserves existing previews from open PRs
+          keep_files: true  # This preserves existing previews from open PRs

.github/workflows/deploy-preview.yaml

@@ -134,4 +134,4 @@ jobs:
           body: |
             ${{ env.comment_message }}
             🔍 Git commit SHA: ${{ steps.find-pull-request.outputs.sha }}
-            ✅ Deployment Preview URL: https://${{ github.repository_owner }}.github.io/${{ steps.repo-name.outputs.value }}/_preview/${{ steps.find-pull-request.outputs.number }}
+            ✅ Deployment Preview URL: https://${{ github.repository_owner }}.github.io/${{ steps.repo-name.outputs.value }}/_preview/${{ steps.find-pull-request.outputs.number }}

.github/workflows/link-checker.yaml

@@ -55,4 +55,4 @@ jobs:
             yaml.dump(data, f)
       - name: Check external links
         run: |
-          jupyter-book build --builder linkcheck ${{ inputs.path_to_notebooks }}
+          jupyter-book build --builder linkcheck ${{ inputs.path_to_notebooks }}

.github/workflows/publish-book.yaml

@@ -18,4 +18,4 @@ jobs:
     with:
       environment_name: erad-2024-dev
       environment_file: environment.yml
-      path_to_notebooks: ./
+      path_to_notebooks: ./

README.md

@@ -11,7 +11,7 @@ This tutorial covers how to get started with the Open Radar Science stack!
 
 The course will take place on 8 September 2024, the day before the [2024 ERAD Radar Conference](https://www.erad2024.it/). The course will discuss the principles of open science and provide an overview of the most mature and exciting software packages available for radar data processing (ex. LROSE, Py-ART, pyrad, BALTRAD, wradlib) and how they connect with the scientific software stack.
 
-The course will be built with Jupyter Notebooks as hands-on approach for interactive user experience. The main course programming language is Python, but also Command Line Tools are used. 
+The course will be built with Jupyter Notebooks as hands-on approach for interactive user experience. The main course programming language is Python, but also Command Line Tools are used.
 
 The course will also highlight the “xradar” package, implementing the newly adopted FM301/CfRadial2 WMO standard, as well as the gpm-api software, which facilitates the
 download and analysis of TRMM PR and GPM DPR spaceborne radars data. These two tools will be used to showcase how to harness the power of xarray and dask for efficient, distributed radar data processing.

binder/Dockerfile

@@ -1 +1 @@
-FROM ghcr.io/openradar/erad2024:pr_65
+FROM ghcr.io/openradar/erad2024:pr_69

binder/appendix.txt

@@ -18,4 +18,5 @@ RUN CONDA_DIR=/srv/conda && \
     echo "export CONDA_PREFIX=$CONDA_PREFIX" >> ~/.profile && \
     echo "export PROJ_NETWORK=$PROJ_NETWORK" >> ~/.profile && \
     ${CONDA_PREFIX}/bin/bash -l $BALTRAD_INSTALL_ROOT/install/baltrad/install_baltrad.sh && \
+    rm -rf $BALTRAD_INSTALL_ROOT/install && \
     cp binder/kernel.json $CONDA_PREFIX/share/jupyter/kernels/python3/.

binder/environment.yml

@@ -15,7 +15,7 @@ dependencies:
   - pydda
   - zarr
   - xarray
-  - xradar
+  - xradar>=0.6.3
   - numpy<2.0
   - python<=3.11
   # this is needed for baltrad compilation

binder/kernel.json

@@ -10,4 +10,4 @@
     "language": "python",
     "env": {"LD_LIBRARY_PATH":":/srv/conda/envs/notebook/lib:/srv/conda/envs/notebook/hlhdf/lib:/srv/conda/envs/notebook/rave/lib:/srv/conda/envs/notebook/beamb/lib:/srv/conda/envs/notebook/bropo/lib:/srv/conda/envs/notebook/baltrad-wrwp/lib",
             "PATH": ":/srv/conda/envs/notebook/bin:/srv/conda/condabin:/home/jovyan/.local/bin:/home/jovyan/.local/bin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/srv/conda/envs/notebook/hlhdf/bin:/srv/conda/envs/notebook/rave/bin:/srv/conda/envs/notebook/beamb/bin:/srv/conda/envs/notebook/bropo/bin:/srv/conda/envs/notebook/baltrad-wrwp/bin"}
-   }
+   }

environment.yml

@@ -10,10 +10,11 @@ dependencies:
   - cartopy
   - matplotlib
   - numpy
+  - pydda
   - pyrad_arm
   - wradlib
   - xarray
-  - xradar
+  - xradar>=0.6.3
   - numpy<2.0
   - python<=3.11
-  - mystmd
+  - mystmd