Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Kotlin 2.1 #627

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

barbulescu
Copy link

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/kotlin/ChangeTypeTest.java
    • lines 18-18

Comment on lines +100 to +103
private fun Any?.isInvalid() = this == null
|| this is FirErrorTypeRef
|| this is FirExpression && this.resolvedType is ConeErrorType
|| this is FirResolvedQualifier && classId == null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private fun Any?.isInvalid() = this == null
|| this is FirErrorTypeRef
|| this is FirExpression && this.resolvedType is ConeErrorType
|| this is FirResolvedQualifier && classId == null
private fun Any?.isInvalid() = this == null ||
this is FirErrorTypeRef ||
this is FirExpression && this.resolvedType is ConeErrorType ||
this is FirResolvedQualifier && classId == null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants