Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rewrite-maven-plugin search for Kotlin source files in src/*/java if src/*/kotlin does not exist #937

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reisners
Copy link

What's changed?

Added an integration test case that verifies that a Kotlin source file under src/main/java was detected and modified by a recipe (Autoformat). This test case initially fails because the rewrite-maven-plugin does not detect Kotlin source files under src/main/java.

What's your motivation?

To demonstrate the issue described in #936

Anything in particular you'd like reviewers to focus on?

I will push the fix in a separate commit.

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

which fails initially because 0 kotlin source files will be found in the non-existent src/main/kotlin
@timtebeek timtebeek marked this pull request as draft January 23, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant