-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to use the opster API's and onboard to OpenSearch universal release mechanism #710
Conversation
…ng `opster` reference) (opensearch-project#698)" This reverts commit 1c72422. Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
2b3bb88
to
eab967b
Compare
Hey @swoehrl-mw can you please take a look and add your review? looks to me like the functional tests are failing because of the image not able to get pulled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prudhvigodithi I suspect it's unable to pull the busybox image (for the init containers) as it does not yet exist.
Next steps are:
|
Thanks @swoehrl-mw and @peterzhuamazon, one more change, I dont think we need to build, push and maintain the busybox image separately , I have modified the logic to use the existing official busybox https://hub.docker.com/_/busybox, any concerns ? |
Yup all the tests pass now, merging the PR. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
I believe it was only mirrored so that people would not potentially run into the dockerhub rate limits. But for most users this should not be a concern. |
Thanks I can change to ECR busybox https://gallery.ecr.aws/docker/library/busybox, as ECR has no rate limits for now. |
Description
Revert to use the opster API's and onboard to OpenSearch universal release process .
Issues Resolved
#709
#674
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.