Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to use the opster API's and onboard to OpenSearch universal release mechanism #710

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Jan 27, 2024

Description

Revert to use the opster API's and onboard to OpenSearch universal release process .

Issues Resolved

#709
#674

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ng `opster` reference) (opensearch-project#698)"

This reverts commit 1c72422.

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi force-pushed the main branch 5 times, most recently from 2b3bb88 to eab967b Compare January 27, 2024 01:32
@prudhvigodithi
Copy link
Member Author

Hey @swoehrl-mw can you please take a look and add your review? looks to me like the functional tests are failing because of the image not able to get pulled.
Thanks
Adding @bbarani @peterzhuamazon

Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prudhvigodithi I suspect it's unable to pull the busybox image (for the init containers) as it does not yet exist.

jenkins/release.jenkinsfile Outdated Show resolved Hide resolved
@prudhvigodithi
Copy link
Member Author

Next steps are:

  • Onboard a jenkins job in https://build.ci.opensearch.org/ that uses the jenkins/release.jenkinsfile.
  • Cut a tag with 2.5.0 which should trigger the above created job to build and push the docker images to ECR and dockerhub.
  • The existing release.yaml will do a helm and github release.

@swoehrl-mw @bbarani @peterzhuamazon

@prudhvigodithi
Copy link
Member Author

Thanks @swoehrl-mw and @peterzhuamazon, one more change, I dont think we need to build, push and maintain the busybox image separately , I have modified the logic to use the existing official busybox https://hub.docker.com/_/busybox, any concerns ?

@prudhvigodithi
Copy link
Member Author

Yup all the tests pass now, merging the PR.

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi merged commit 81db8a3 into opensearch-project:main Jan 30, 2024
6 checks passed
@swoehrl-mw
Copy link
Collaborator

I have modified the logic to use the existing official busybox https://hub.docker.com/_/busybox, any concerns ?

I believe it was only mirrored so that people would not potentially run into the dockerhub rate limits. But for most users this should not be a concern.

@prudhvigodithi
Copy link
Member Author

Thanks I can change to ECR busybox https://gallery.ecr.aws/docker/library/busybox, as ECR has no rate limits for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants